Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated xxhash to latest dev branch commit #4273

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

updated xxhash to latest dev branch commit #4273

wants to merge 2 commits into from

Conversation

Cyan4973
Copy link
Contributor

this version supports redirection of XXH_memcpy and XXH_memset.
This capability is used during local zstd adaptation to redirect to zstd_deps.h's ZSTD_memcpy and ZSTD_memset.

@Cyan4973
Copy link
Contributor Author

Cyan4973 commented Jan 29, 2025

The visual studio compilation error in xxhash.h is kinda new.

More worrying, I can't make sense of the error message :

D:\a\zstd\zstd\lib\common\xxhash.h(3182): error C4702: unreachable code [D:\a\zstd\zstd\build\VS2010\fuzzer\fuzzer.vcxproj]

When looking at xxhash.h(3182), it does not feel correct.
This code is obviously reachable and reached, it's very simple code, nothing weird happening there.

One possibility is that the line number 3182 might be completely wrong,
but then it doesn't help identifying what could be the problem.

No other compiler triggers this warning.
I also note that the issue only happens in combination with fuzzer.c, compilation of xxhash is fine within libzstd or any other program.

this one supports redirection of XXH_memcpy and XXH_memset
which is used here to redirect to `zstd_deps.h`'s ZSTD_memcpy and ZSTD_memset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants