-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building on Solaris 10 x86_64 GCC 4.9.2 #3861
base: dev
Are you sure you want to change the base?
Conversation
This PR conflicts with an old patch that was recently merged. |
66f4d85
to
185ea24
Compare
Prevent building x86_64 ASM from Solaris x86_64
185ea24
to
19ccc50
Compare
Fixed |
I finally found the time to create a Solaris test for Github Actions. The test includes running Among the potential differences that could explain this surprising outcome: Conversely, it also means that this patch might be a bit too strong: Therefore, it seems a more adjusted solution would be to limit removal of asm support for Solaris version 10 and below. |
You are right. Checking if x86_64 ASM source can be compiled in I will try to do it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find a different way for this constraint (no-asm) to be more limited,
since Solaris 11.4 (at least) doesn't seem to need it.
Prevent building x86_64 ASM from Solaris x86_64