fix: Proof de/serialization

[SantiagoPittella]

Serialization of the Proof struct was failing due to a missing field in the Context serialization and because it was not writing the number of trace queries.

[facebook-github-bot]

Hi @SantiagoPittella!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[irakliyk]

Thank you for finding this issue. There are actually two separate problems here which need a different fix.

• First, the dummy proof wasn't being constructed correctly (i.e., it was internally inconsistent). This caused an issue for deserializing dummy proofs specifically (when correct proofs were working).
• Second, in v0.12.0 release, we broke Context struct serialization. Thus, serialization of valid proofs was failing as well.

I fixed both issues in b067ed5 and published the winter-air crate v0.12.1 with this fix.

Also, separately, I fixed dummy proof construction and released winter-air v0.11.1 crate.

Let me know if you are still seeing any issues with the new crate versions.

[SantiagoPittella]

Thank for the releases! I just checked it and solved my issue.

I'm closing this PR since it is completed. 🚀