Skip to content

Commit

Permalink
edensparse: allow config overrides when making matcher
Browse files Browse the repository at this point in the history
Summary: FilteredFS (AKA edensparse) was ignoring the `config` arg to sparsematcher(), but that arg is important for sparse commands like debugsparsematch or debugsparseexplainmatch (which are useful to debug sparse profiles without needing a sparse clone). Let's just let it do its thing.

Reviewed By: sggutier

Differential Revision: D56164263

fbshipit-source-id: f0c1d0c0043b75e54f9c6eabe29797d5f466c156
  • Loading branch information
muirdm authored and facebook-github-bot committed Apr 16, 2024
1 parent 31a7400 commit 78bd513
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions eden/scm/sapling/ext/sparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -1002,8 +1002,7 @@ def sparsematch(self, *revs, **kwargs):

includetemp = kwargs.get("includetemp", True)

# Don't allow overrides for edensparse checkouts
rawconfig = kwargs.get("config") if not _isedensparse(self) else None
rawconfig = kwargs.get("config")

cachekey = self._cachekey(revs, includetemp=includetemp)

Expand Down
3 changes: 1 addition & 2 deletions eden/scm/tests/test-eden-sparse.t
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@
$ hg clone -q --eden test:server client --config clone.eden-sparse-filter=eden-sparse
$ cd client

FIXME Allow adhoc use of sparse commands to debug sparse profiles:
Allow adhoc use of sparse commands to debug sparse profiles:
$ hg debugsparsematch -q --sparse-profile=sparse excluded --config extensions.sparse=
excluded

0 comments on commit 78bd513

Please sign in to comment.