Skip to content

[ci] Only checkout if no cache hit #32856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ci] Only checkout if no cache hit #32856

wants to merge 2 commits into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Apr 11, 2025

We don't need to do a checkout for the node_modules cache jobs if there's a cache hit. Saves a few seconds.

Stack created with Sapling. Best reviewed with ReviewStack.

Try to upgrade our node version.
We don't need to do a checkout for the node_modules cache jobs if there's a cache hit. Saves a few seconds.
@react-sizebot
Copy link

Comparing: 1d6c816...8b38201

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 516.18 kB 516.18 kB = 91.88 kB 91.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 621.49 kB 621.49 kB = 110.01 kB 110.01 kB
facebook-www/ReactDOM-prod.classic.js = 654.79 kB 654.79 kB = 115.57 kB 115.57 kB
facebook-www/ReactDOM-prod.modern.js = 645.07 kB 645.07 kB = 114.04 kB 114.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8b38201

@poteto poteto closed this Apr 12, 2025
@poteto poteto deleted the pr32856 branch April 12, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants