[compiler] Delete LoweredFunction.dependencies and hoisted instructions #32096
+779
−506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
facebook-github-bot
added
CLA Signed
React Core Team
Small patch to pass aliased context values into `Object|ArrayExpression`s
See test fixture
See test fixture
LoweredFunction dependencies were exclusively used for dependency extraction (in `propagateScopeDeps`). Now that we have a `propagateScopeDepsHIR` that recursively traverses into nested functions, we can delete `dependencies` and their associated artificial `LoadLocal`/`PropertyLoad` instructions. ' Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoweredFunction dependencies were exclusively used for dependency extraction (in
propagateScopeDeps). Now that we have apropagateScopeDepsHIRthat recursively traverses into nested functions, we can deletedependenciesand their associated artificialLoadLocal/PropertyLoadinstructions.'
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Stack created with Sapling. Best reviewed with ReviewStack.