Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JSXElement): React19 regression: element._store may not be present in mixed dev/prod environment #32061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smeng9
Copy link

@smeng9 smeng9 commented Jan 13, 2025

Summary

@yungsters @javache

Fix comments in #29662 (comment)

Hi @yungsters, we have encountered issue that such keys does not exist.

Our use case is as follows, we use microfrontend where some part of code is built with production flag and loaded through https://github.com/Paciolan/remote-component and some other part of the code is used in development mode.

Production code in react does not have private variables like _store and when cloning it certainly has problem.

Please check for the existences of _store.

How did you test this change?

React 18 does not have such issue, and upgrading to react 19 should behave the same when doing development.

Screenshot 2025-01-13 at 3 09 37 PM

@yungsters
Copy link
Contributor

I submitted #32117, which also includes a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants