Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Start prerendering Suspense retries immediately (#30934)" #30998

Closed
wants to merge 1 commit into from
Closed

Revert "Start prerendering Suspense retries immediately (#30934)" #30998

wants to merge 1 commit into from

Conversation

jackpope
Copy link
Contributor

This reverts commit d6cb4e7.

Temporary revert to check changes in logging

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 10:42pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 18, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 18, 2024 •
edited
Loading

Comparing: e72127a...c30785b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.22 kB 506.90 kB = 90.95 kB 90.72 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.15 kB 511.83 kB = 91.67 kB 91.44 kB
facebook-www/ReactDOM-prod.classic.js = 602.57 kB 600.64 kB = 106.64 kB 106.30 kB
facebook-www/ReactDOM-prod.modern.js = 578.84 kB 576.93 kB = 102.76 kB 102.44 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 963.21 kB 961.00 kB = 164.05 kB 163.75 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 962.71 kB 960.50 kB = 163.05 kB 162.74 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js = 954.50 kB 952.27 kB = 161.61 kB 161.34 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.development.js = 954.40 kB 952.16 kB = 161.59 kB 161.31 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js = 954.40 kB 952.16 kB = 161.59 kB 161.31 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 946.27 kB 944.06 kB = 160.23 kB 159.91 kB
oss-stable/react-dom/cjs/react-dom-client.development.js = 938.06 kB 935.83 kB = 158.78 kB 158.50 kB
oss-stable-rc/react-dom/cjs/react-dom-client.development.js = 937.95 kB 935.72 kB = 158.76 kB 158.48 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js = 937.95 kB 935.72 kB = 158.76 kB 158.48 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 542.34 kB 541.01 kB = 96.65 kB 96.39 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js = 538.64 kB 537.30 kB = 95.74 kB 95.52 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.profiling.js = 538.53 kB 537.19 kB = 95.72 kB 95.50 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js = 538.53 kB 537.19 kB = 95.72 kB 95.50 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 527.88 kB 526.56 kB = 95.31 kB 95.11 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.15 kB 511.83 kB = 91.67 kB 91.44 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.22 kB 506.90 kB = 90.95 kB 90.72 kB
oss-stable-rc/react-dom/cjs/react-dom-client.production.js = 508.11 kB 506.79 kB = 90.93 kB 90.70 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js = 508.11 kB 506.79 kB = 90.93 kB 90.70 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,102.60 kB 1,099.54 kB = 186.07 kB 185.71 kB
facebook-www/ReactDOM-dev.classic.js = 1,085.70 kB 1,082.64 kB = 182.11 kB 181.74 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,066.71 kB 1,063.67 kB = 179.98 kB 179.61 kB
facebook-www/ReactDOM-dev.modern.js = 1,049.80 kB 1,046.77 kB = 176.11 kB 175.74 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 991.20 kB 988.20 kB = 167.21 kB 166.81 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 974.86 kB 971.86 kB = 164.39 kB 163.99 kB
facebook-www/ReactDOM-profiling.classic.js = 630.59 kB 628.63 kB = 110.63 kB 110.32 kB
facebook-www/ReactDOMTesting-prod.classic.js = 617.31 kB 615.38 kB = 110.36 kB 110.02 kB
facebook-www/ReactDOM-profiling.modern.js = 606.20 kB 604.27 kB = 106.62 kB 106.34 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 385.39 kB 384.16 kB = 66.91 kB 66.71 kB
facebook-www/ReactDOM-prod.classic.js = 602.57 kB 600.64 kB = 106.64 kB 106.30 kB
facebook-www/ReactDOMTesting-prod.modern.js = 593.57 kB 591.67 kB = 106.47 kB 106.15 kB
react-native/implementations/ReactFabric-profiling.js = 375.73 kB 374.50 kB = 65.13 kB 64.92 kB
react-native/implementations/ReactNativeRenderer-dev.js = 641.20 kB 639.09 kB = 105.27 kB 105.02 kB
facebook-www/ReactDOM-prod.modern.js = 578.84 kB 576.93 kB = 102.76 kB 102.44 kB
react-native/implementations/ReactFabric-dev.js = 629.99 kB 627.88 kB = 103.24 kB 102.99 kB
react-native/implementations/ReactNativeRenderer-prod.js = 360.15 kB 358.94 kB = 63.07 kB 62.89 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 643.25 kB 641.04 kB = 103.46 kB 103.19 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 564.16 kB 562.21 kB = 99.77 kB 99.45 kB
react-native/implementations/ReactFabric-prod.js = 350.49 kB 349.28 kB = 61.40 kB 61.21 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 579.07 kB 577.05 kB = 94.40 kB 94.14 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 635.70 kB 633.48 kB = 102.14 kB 101.88 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.development.js = 635.68 kB 633.46 kB = 102.12 kB 101.86 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 635.68 kB 633.46 kB = 102.12 kB 101.86 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 558.22 kB 556.27 kB = 98.62 kB 98.30 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 345.17 kB 343.94 kB = 60.12 kB 59.91 kB
facebook-www/ReactTestRenderer-dev.classic.js = 573.29 kB 571.24 kB = 93.77 kB 93.53 kB
facebook-www/ReactTestRenderer-dev.modern.js = 573.28 kB 571.23 kB = 93.77 kB 93.53 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 538.79 kB 536.86 kB = 95.95 kB 95.57 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 414.15 kB 412.66 kB = 67.78 kB 67.55 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 389.23 kB 387.82 kB = 63.83 kB 63.61 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 533.29 kB 531.36 kB = 94.87 kB 94.50 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js = 384.15 kB 382.74 kB = 63.00 kB 62.78 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.production.js = 384.12 kB 382.72 kB = 62.98 kB 62.76 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js = 384.12 kB 382.72 kB = 62.98 kB 62.76 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js = 410.41 kB 408.89 kB = 66.73 kB 66.49 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.profiling.js = 410.39 kB 408.87 kB = 66.71 kB 66.45 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js = 410.39 kB 408.87 kB = 66.71 kB 66.45 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 548.53 kB 546.48 kB = 89.67 kB 89.43 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 545.97 kB 543.92 kB = 89.27 kB 89.03 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.development.js = 545.90 kB 543.85 kB = 89.24 kB 89.01 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 545.90 kB 543.85 kB = 89.24 kB 89.01 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 323.32 kB 322.11 kB = 56.99 kB 56.80 kB
oss-experimental/react-art/cjs/react-art.development.js = 561.74 kB 559.62 kB = 91.04 kB 90.78 kB
oss-stable/react-art/cjs/react-art.development.js = 553.11 kB 550.98 kB = 89.57 kB 89.32 kB
oss-stable-rc/react-art/cjs/react-art.development.js = 553.05 kB 550.91 kB = 89.55 kB 89.30 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 553.05 kB 550.91 kB = 89.55 kB 89.30 kB
oss-experimental/react-art/cjs/react-art.production.js = 303.28 kB 302.05 kB = 52.15 kB 51.96 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 308.37 kB 307.11 kB = 54.60 kB 54.40 kB
facebook-www/ReactReconciler-dev.classic.js = 740.52 kB 737.48 kB = 118.09 kB 117.70 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js = 305.96 kB 304.70 kB = 54.14 kB 53.94 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js = 305.89 kB 304.64 kB = 54.12 kB 53.91 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js = 305.89 kB 304.64 kB = 54.12 kB 53.91 kB
oss-stable/react-art/cjs/react-art.production.js = 298.77 kB 297.53 kB = 51.40 kB 51.20 kB
oss-stable-rc/react-art/cjs/react-art.production.js = 298.70 kB 297.47 kB = 51.38 kB 51.18 kB
oss-stable-semver/react-art/cjs/react-art.production.js = 298.70 kB 297.47 kB = 51.38 kB 51.18 kB
facebook-www/ReactReconciler-dev.modern.js = 716.62 kB 713.60 kB = 113.97 kB 113.62 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 665.62 kB 662.72 kB = 109.16 kB 108.81 kB
react-native/implementations/ReactFabric-dev.fb.js = 658.40 kB 655.50 kB = 107.68 kB 107.34 kB
facebook-www/ReactReconciler-prod.classic.js = 462.42 kB 460.38 kB = 75.01 kB 74.66 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 410.46 kB 408.60 kB = 71.25 kB 70.94 kB
facebook-www/ReactART-dev.classic.js = 654.06 kB 651.08 kB = 104.75 kB 104.36 kB
facebook-www/ReactReconciler-prod.modern.js = 443.64 kB 441.61 kB = 72.18 kB 71.87 kB
react-native/implementations/ReactFabric-profiling.fb.js = 404.83 kB 402.96 kB = 70.11 kB 69.80 kB
facebook-www/ReactART-dev.modern.js = 631.57 kB 628.62 kB = 101.04 kB 100.67 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 384.91 kB 383.07 kB = 67.39 kB 67.10 kB
react-native/implementations/ReactFabric-prod.fb.js = 379.25 kB 377.40 kB = 66.18 kB 65.90 kB
facebook-www/ReactART-prod.classic.js = 369.67 kB 367.79 kB = 62.59 kB 62.25 kB
facebook-www/ReactART-prod.modern.js = 352.64 kB 350.78 kB = 59.84 kB 59.51 kB

Generated by 🚫 dangerJS against aaf618a

@josephsavona
Copy link
Contributor

Temporary revert to check changes in logging

What's the plan exactly?

@josephsavona
Copy link
Contributor

Chatted with @jackpope offline. Context is that we're seeing some regressions due to additional rendering and suspect that this PR might be the cause. We're going to try to run tests via a custom build but if that proves infeasible we may have to proceed with the revert and a quick reland later.

rickhanlonii
rickhanlonii requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just revert the internal diffs

@jackpope
Copy link
Contributor Author

Internal revert showed this is not the cause of regressions. Closing.

@jackpope jackpope closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii requested changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackpope @react-sizebot @josephsavona @rickhanlonii @facebook-github-bot