Upgrade devtools extension manifest to version 3

[AnmolBansalDEV]

resolves #24522

Summary

since google is pulling the plug on manifestV2, I upgraded the manifest.json files for chrome, edge, and firefox to V3

How did you test this change?

I checked against the google guide for all changes being made.

[facebook-github-bot]

Hi @AnmolBansalDEV!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[mondaychen]

Thanks for the contribution!
I'll look into this on Monday. Just FYI it might take some time before we can merge this, because we need to make sure all the features still work fine with V3, on all 3 browsers we support.

I'm actually surprised no JS file needed to be changed. For example, according to this section, chrome.browserAction needs to be changed to chrome.action.

[chapmanm3]

To add to @mondaychen 's comment I took a look into this issue and I think because of the switch from background pages to service workers with V3 link There is no longer access to XMLHttpRequest which happens here, that logic may also need to be updated.

[mondaychen]

How did you test the extension? I'm getting this error when loading the local build

[AnmolBansalDEV]

hey, I've included your recommendation in the code, but I'm facing trouble with how to test the extension. Is there any react community where I can ask doubts?

also, I tried to solve the issue @chapmanm3 highlighted but, it says in the code that the request has to be synchronous, If I replace XHR with fetch API, It will be asynchronous, not synchronous.

[mondaychen]

@AnmolBansalDEV You can just ask in the original issue. In fact, I'd recommend you to figure out how to test the extension before you create a PR about it. I'll close this PR for now since it looks like you need to get a lot done before it's ready for review. You can re-open it after you fixed the issues.

[mondaychen]

To answer your question regarding XHR, you can wrap the logic into the then of the Promise

[SijaanX]

Replied here by mistake