fix -Wshadow issue #9437
Open
fix -Wshadow issue #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54112254 |
Summary:
-Wshadow triggered in LLVM-17:
```
fbcode/folly/futures/ThreadWheelTimekeeper.cpp:61:42: error: declaration shadows a structured binding [-Werror,-Wshadow]
61 | eventBase_.runInEventBaseThread([this, cob = std::move(cob), dur] {
| ^
fbcode/folly/futures/ThreadWheelTimekeeper.cpp:47:9: note: previous declaration is here
47 | auto [cob, sf] = WTCallback<HHWheelTimer>::create(&eventBase_);
| ^
```
This seems to only be triggered in llvm-17, llvm-15 doesn't pick it up:
```
$ buck2 build -c cxx.extra_cxxflags=-Wshadow folly/futures:core
...
BUILD SUCCEEDE
```
Differential Revision: D54112254
palmje
force-pushed
the
export-D54112254
branch
from
44fc669
to
88da2bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54112254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
-Wshadow triggered in LLVM-17:
This seems to only be triggered in llvm-17, llvm-15 doesn't pick it up:
Differential Revision: D54112254