-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OpenSSL version to 3.0 #9277
base: master
Are you sure you want to change the base?
Conversation
This reverts commit d7e5d0c.
@Atry has updated the pull request. You must reimport the pull request before landing. |
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This PR reverts d7e5d0c and fixes compatibility issues with OpenSSL 3.0 in
ext_openssl.cpp
, due to the breaking change in OpenSSL 3.0 that makesget0
functions returnconst
pointers.Some
EVP_PKEY_get0_RSA
are replaced withEVP_PKEY_get1_RSA
in order to get a mutable pointer with the ownership. See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS