Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenSSL version to 3.0 #9277

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

Upgrade OpenSSL version to 3.0 #9277

wants to merge 52 commits into from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Oct 27, 2022

This PR reverts d7e5d0c and fixes compatibility issues with OpenSSL 3.0 in ext_openssl.cpp, due to the breaking change in OpenSSL 3.0 that makes get0 functions return const pointers.

Some EVP_PKEY_get0_RSA are replaced with EVP_PKEY_get1_RSA in order to get a mutable pointer with the ownership. See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS

facebook-github-bot and others added 30 commits October 13, 2022 03:52
@Atry Atry changed the title Revert "Pin OpenSSL version to 1.1" Upgrade OpenSSL version to 3.0 Oct 28, 2022
@Atry Atry marked this pull request as ready for review October 28, 2022 16:50
@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3
@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Atry Atry marked this pull request as draft November 2, 2022 17:30
@facebook-github-bot
Copy link
Contributor

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants