Add support for Symbol member expression in class method definition #1602
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68766740 |
…acebook#1602) Summary: ## Summary: This diff introduces support for [Symbol.iterator] and [Symbol.asyncIterator] as a method definition in flow defs generation. It can be confirmed in the flow lexer that these are the only two tokens prefixed with `@@`. Previously, that type of code wasn't supported and caused an exception: ```js export default { [Symbol.iterator]() {}; [Symbol.asyncIterator]() {}; } ``` The generated output if the type is not specified should be: ```js declare export default { @iterator(): void; @asyncIterator(): void; } ``` There are a few places in react-native source that will benefit from this, like: DOMRectList, URLSeachParams, NodeList and HTMLCollection. Changelog: [flow-api-translator] - Added support for Symbol member expression in class method definition Reviewed By: pieterv Differential Revision: D68766740
coado
force-pushed
the
export-D68766740
branch
from
a536ea8 to
1917c0f
Compare
coado
added a commit
to coado/hermes
that referenced
this pull request
Jan 29, 2025
…acebook#1602) Summary: ## Summary: This diff introduces support for [Symbol.iterator] and [Symbol.asyncIterator] as a method definition in flow defs generation. It can be confirmed in the flow lexer that these are the only two tokens prefixed with `@@`. Previously, that type of code wasn't supported and caused an exception: ```js export default { [Symbol.iterator]() {}; [Symbol.asyncIterator]() {}; } ``` The generated output if the type is not specified should be: ```js declare export default { @iterator(): void; @asyncIterator(): void; } ``` There are a few places in react-native source that will benefit from this, like: DOMRectList, URLSeachParams, NodeList and HTMLCollection. Changelog: [flow-api-translator] - Added support for Symbol member expression in class method definition Reviewed By: pieterv Differential Revision: D68766740
coado
force-pushed
the
export-D68766740
branch
from
1917c0f to
fcae4ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68766740 |
coado
force-pushed
the
export-D68766740
branch
from
fcae4ff to
1917c0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68766740 |
|
This pull request has been merged in 1c921f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces support for [Symbol.<...>] as a method definition. Previously, that type of code wasn't supported and caused an exception:
The generated output if the type is not specified should be:
There are a few places in react-native source that will benefit from this, like: DOMRectList, URLSeachParams, NodeList and HTMLCollection.
Changelog:
[flow-api-translator] - Added support for Symbol member expression in class method definition
Differential Revision: D68766740