Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tahan: config: add tahan dvt qsfp config file #223

Closed
wants to merge 2 commits into from

Conversation

zhongedward
Copy link
Contributor

@zhongedward zhongedward commented Sep 6, 2024

Description
This PR is for janga dvt qsfp config file.

Motivation
1.This is new added qsfp config file in tahan dvt machine(note: this file is approved from https://github.com/facebookexternal/fboss.bsp.celestica/blob/master/tahan/osfp/qsfp.conf) i just copy it here and then raise it again.
2.Test cmd:

Test cmd:
./bin/run_test.py qsfp --qsfp-config qsfp.conf --filter_file=./share/hw_sanity_tests/bsp_sanity_tests.conf

Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.This PR has used "jq" cmd to pretty the format.
3.The lint issue is not about the json file.
image

4.Test log as follow:

image

hwtest_results_2022_Aug_28-10_37_25_AM.csv
tahan_oss_test_log_12.18.txt

@facebook-github-bot
Copy link
Contributor

Hi @zhongedward!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@clslucas
Copy link
Contributor

clslucas commented Sep 6, 2024

signed individual license.

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zhongedward has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@mikechoifb mikechoifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongedward The config we got from you is very helpful reference. Meta probably would not like to merge this PR as this is a good reference but not the running config in Meta. Instead, we can check in the PR in our BSP directory. Is this OK?

@karthik-gengan
Copy link

@mikechoifb
Thanks for your guidance. We will update in BSP GITHUB. The Shanghai team will be on a National Day Holiday from Sept 30th to Oct 7th. We will close this PR after they return.

@zhongedward zhongedward closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants