Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

montblanc: config: updated PM config to support 2nd source #216

Closed
wants to merge 4 commits into from

Conversation

clslucas
Copy link
Contributor

Description

Updated the platform manager config to support 2nd source based on 'VersionedPmUnitConfig' in fboss with latest source code.

Note: Currently, the sensor service is limited in supporting a second source configuration using a configuration file.

main source sensor config:
image

2nd source sensor config failed info:
image

Motivation
Added 2nd source config with two interchangeable chips based on 'VersionedPmUnitConfig'.
image

Test Plan

  • build the latest fboss bsp kmod.
  • build the latest fboss platform manager binary.
  • Run the platform manager with the changed config files on DVT and 2nd source DVT device normally.
  • Run fw_util check unit version information.
  • Run the weutil check the unit eeprom data and product sub version.

main source board tested log:
Montblanc_replace_parts_main_source_platform_manager_log_20240822.txt

2nd source board tested log:
Montblanc_replace_parts_2nd_source_platform_manager_log_20240822.txt

@facebook-github-bot
Copy link
Contributor

Hi @clslucas!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@clslucas has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@clslucas has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mikechoifb merged this pull request in 410a84d.

facebook-github-bot pushed a commit that referenced this pull request Sep 30, 2024
… 2nd source (#238)

Summary:
**Description**
Updated the sensors service config to support 2nd source in fboss with latest source code with the latest platform manager config file: #216

There lint issue with below detial info:
![image](https://github.com/user-attachments/assets/2cef6f10-09f9-4502-8b9f-5d5d31db5162)

**Motivation**
Added 2nd source config with two interchangeable chips based on the field "versionedSensors".
![image](https://github.com/user-attachments/assets/b36322d8-fd99-48ff-b59d-57f730e7a206)
Montblanc sensor config lists:
https://docs.google.com/spreadsheets/d/1V_JFLw2m0Zu1DUgVeVPKSGsQrPkRYgCh/edit?gid=1703809973#gid=1703809973

Removed the V2 folder to ensure compatibility with the second source using a single configuration file.

**Test Plan**

- Use the jq command to format the JSON file for improved readability.
- build the latest fboss bsp kmod.
- build the latest fboss platform manager binary.
- Run the platform manager with the changed config files on DVT and 2nd source DVT device normally: LD_LIBRARY_PATH=./fboss_lib/ ./platform_manager --config_file platform_manager.json --run_once=false --noenable_pkg_mgmnt
- Run sensor_service with the new config file: LD_LIBRARY_PATH=./fboss_lib/ ./sensor_service --config_file sensor_service.json

Current tested the new config file on two tpye board normal.
[montblanc_sensor_config_MP_test_log_20240924.txt](https://github.com/user-attachments/files/17112137/montblanc_sensor_config_MP_test_log_20240924.txt)
[montblanc_sensor_config_IFX_test_log_20240924.txt](https://github.com/user-attachments/files/17112138/montblanc_sensor_config_IFX_test_log_20240924.txt)

Pull Request resolved: #238

Reviewed By: kimdo8736

Differential Revision: D63484341

Pulled By: mikechoifb

fbshipit-source-id: 8f84cd950fe1212e9cd6f98ddda6dd6805f38b25
@clslucas clslucas deleted the montblanc_2nd_source_config branch October 9, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants