-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] #2885
Draft
jczhuoMeta
wants to merge
9
commits into
MICE
Choose a base branch
from
MICE-fork
base: MICE
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ### Changes proposed in this Pull Request: Changed the prepare release workflow to use main branch instead of trunk. ### Detailed test instructions: Create a PR for a new release. It should try to merge to main instead of trunk, and also compare to main for readme.txt, etc. Pull Request resolved: #2869 Reviewed By: grepfruit Differential Revision: D69296693 Pulled By: vahidkay-meta fbshipit-source-id: 985884a9ecae80b59b08df7ebbe224d04af4d2d6
Preliminary diff (using some Magento public primitives) allowing MICE Splash Page to be loaded in WooC Extension Next steps: 1. Implement token storage 2. Implement MICE Management page
Summary: ### Changes proposed in this Pull Request: - Adding simple Request and Response tests to the Products Delete API to increase code coverage and as a ramp-up work item for getting used to the dev flow in this repository - [x] Do the changed files pass `phpcs` checks? Please remove `phpcs:ignore` comments in changed files and fix any issues, or delete if not practical. Pull Request resolved: #2865 Test Plan: - `phpunit tests/Unit/Api/ProductCatalog/Products/Delete` Reviewed By: jczhuoMeta, vinkmeta Differential Revision: D68915742 Pulled By: carterbuce fbshipit-source-id: d7fb475ccc1f0c24632e8579d56feb5cb4bc54d2
Summary: ### Changes proposed in this Pull Request: ### Changelog entry Bumping up the version number to 3.3.4 Pull Request resolved: #2881 Reviewed By: akpurifb Differential Revision: D69455861 Pulled By: vahidkay-meta fbshipit-source-id: ec3e9282e3ff5a383dabc564eabfdbba71005666
Summary: ### Add Rich Text Description to Woo Product Sync with Meta #### Description This PR introduces a new feature to the Facebook WooCommerce Plugin, allowing users to add rich text descriptions to their products. With this update, we can seamlessly synchronize the rich text description field with the Facebook Commerce Manager platform. It also adds functionality for a WYSIWYG input box for the Facebook Description field in the plugin #### Changes - Updated the product sync logic to handle rich text formatting. - Modified the API payload to include the rich text description field. - Tested for compatibility with common formatting options (bold, italic, lists, links, etc.). #### Benefits - Improves the visual appeal of product descriptions on Meta. - Ensures consistent branding and formatting across platforms. - Enhances user engagement by presenting more structured and detailed product information. #### Testing Instructions 1. Enable the WooCommerce to Meta product sync. 2. Create or edit a product in WooCommerce with a rich text description (e.g., headings, bold, italic, lists). 3. Sync the product and verify that the description appears correctly formatted on Meta. #### Screenshots <img width="1244" alt="Screenshot 2024-11-04 at 11 21 23" src="https://github.com/user-attachments/assets/eb1c1fbb-5734-4c27-b710-1e031f1a58e6"> <img width="601" alt="Screenshot 2024-11-04 at 11 22 26" src="https://github.com/user-attachments/assets/a40f84e8-3127-4b62-a87d-c172ab257a98"> <img width="753" alt="Screenshot 2024-11-04 at 11 22 41" src="https://github.com/user-attachments/assets/75063389-5a78-4ae2-a73f-c2a392427472"> <img width="740" alt="Screenshot 2024-12-24 at 18 24 52" src="https://github.com/user-attachments/assets/e011e53e-9892-4e06-ace1-bfd7e22dab22" /> --- #### Additional Notes Please let me know if there are any edge cases or scenarios that should be tested further. Pull Request resolved: #2843 Reviewed By: vinkmeta Differential Revision: D69199179 Pulled By: devbodaghe fbshipit-source-id: 8d620efa52fe16c9c936dc8ad4136689d273dc8c
Preliminary diff (using some Magento public primitives) allowing MICE Splash Page to be loaded in WooC Extension Next steps: 1. Implement token storage 2. Implement MICE Management page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes # .
Replace this with a good description of your changes & reasoning.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Screenshots:
Detailed test instructions:
Additional details:
Changelog entry