Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice router #38

Open
freemvmt opened this issue Dec 20, 2019 · 0 comments
Open

Nice router #38

freemvmt opened this issue Dec 20, 2019 · 0 comments
Labels
compliment enhancement New feature or request

Comments

@freemvmt
Copy link

Pronounced row-ter of course ;)

Your central controllers (controllers/index.js) file is really good, I can tell immediately what's going on from reading it. Very clear!

Also nice that you've removed some functions from immediate view, as with controllers/behaviour.js.

Could be neatened up by abstracting the controllers into separate files, like you have for the client and server routes imported from the error.js file.

Then you could easily see all your routes at one glance, e.g.

router.get('/', home.get)
router.get('create-user', user.post)
router.get('presents', presents.get)
router.use(error.client);
router.use(error.server);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliment enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant