modularize controllers/index.js

[rooberrydev]

since you already have an empty file for home, I would move the callback for the "/" route handler to this file.

week8-jach/src/controllers/index.js

Lines 12 to 14 in 84ec974

	router.get("/", (req, res) => {
	res.render("home", { questions: questionsList });
	});

change this to

router.get("/", getHome)

or similar, where getHome would be imported in from home.js

you can do the same for

week8-jach/src/controllers/index.js

Lines 18 to 60 in 84ec974

	router.post("/create-user", (req, res) => {
	// console.log(req.body);
	const questionsArray = [
	req.body.q1,
	req.body.q2,
	req.body.q3,
	req.body.q4,
	req.body.q5,
	req.body.q6,
	req.body.q7
	];
	let goodOrBad;
	let totalPoint = behaviour(questionsArray);
	if (totalPoint >= 4) {
	goodOrBad = true;
	} else {
	goodOrBad = false;
	}
	postData({
	name: req.body.username,
	behaviour: goodOrBad,
	category: req.body.category
	})
	.then(responseDb => {
	res.redirect("/presents");
	})
	.catch(error => {
	throw error;
	});
	// res.redirect('/presents');
	});
	router.get("/presents", (req, res) => {
	console.log("we're getting data");
	getData()
	.then(users => res.render("presents", { users }))
	.catch(err => {
	throw err;
	});
	});

and abstract the callbacks into separate files.

leaving your index.js cleaner and looking like this

router.get("/",getHome)
router.post("/create-user",createUser)
router.get("/presents",getPresents)

where getHome, createUser and getPresents are functions imported in. refer to the express workshop if you need help with this 👍 😄

[rooberrydev]

#38

by dan is the same issue btw