-
Notifications
You must be signed in to change notification settings - Fork 4
Update Package.swift and README.md on feature/swift 5.2
branch
#31
Update Package.swift and README.md on feature/swift 5.2
branch
#31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the readme. I'm not sure though if the Package.swift
change is what we want.
Package.swift
Outdated
@@ -1,4 +1,4 @@ | |||
// swift-tools-version:5.1 | |||
// swift-tools-version:5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we increase the version here, every importing package must also be on swift 5.2 afaik. I'm not sure if we want to drop support for 5.1 yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! I'll change that back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the other changes in Package.swift
when building with Xcode 11.4 though
18523ad
to
4d0bfc6
Compare
4d0bfc6
to
5122253
Compare
5122253
to
4d38b09
Compare
f4c736f
to
b372f68
Compare
b372f68
to
946a17f
Compare
No description provided.