Skip to content
This repository was archived by the owner on Jul 14, 2020. It is now read-only.

Update Package.swift and README.md on feature/swift 5.2 branch #31

Merged
merged 8 commits into from
Apr 15, 2020
Merged

Update Package.swift and README.md on feature/swift 5.2 branch #31

merged 8 commits into from
Apr 15, 2020

Conversation

alfavata
Copy link
Contributor

@alfavata alfavata commented Apr 7, 2020

No description provided.

Copy link
Owner

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the readme. I'm not sure though if the Package.swift change is what we want.

Package.swift Outdated
@@ -1,4 +1,4 @@
// swift-tools-version:5.1
// swift-tools-version:5.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we increase the version here, every importing package must also be on swift 5.2 afaik. I'm not sure if we want to drop support for 5.1 yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! I'll change that back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the other changes in Package.swift when building with Xcode 11.4 though

@fabianfett fabianfett merged commit a7ea849 into fabianfett:feature/swift-5.2 Apr 15, 2020
@alfavata alfavata deleted the feature/swift-5.2 branch April 15, 2020 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants