This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Moved .forTesting() functions to new importable LambdaRuntimeTestUtils target #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 13, 2020 15:54
…forTesting() and other testing utility code.
fabianfett
suggested changes
Jan 13, 2020
| @@ -5,7 +5,7 @@ import NIOHTTP1 | |||
|
|
|||
Package.swift
Outdated
| .testTarget(name: "LambdaRuntimeTests", dependencies: ["LambdaRuntime", "NIOTestUtils", "Logging"]) | ||
| .target( | ||
| name: "LambdaRuntimeTestUtils", | ||
| dependencies: ["LambdaRuntime"] |
There was a problem hiding this comment.
we need to add NIOHTTP1 here, since we use HTTPHeaders
Package.swift
Outdated
| name: "LambdaRuntimeTestUtils", | ||
| dependencies: ["LambdaRuntime"] | ||
| ), | ||
| .testTarget(name: "LambdaRuntimeTests", dependencies: ["LambdaRuntime", "NIOTestUtils", "Logging", "LambdaRuntimeTestUtils"]) |
There was a problem hiding this comment.
Code beauty:
.testTarget(name: "LambdaRuntimeTests", dependencies: [
"LambdaRuntime",
"LambdaRuntimeTestUtils",
"NIOTestUtils",
"Logging",
])| @@ -1,6 +1,7 @@ | |||
| import Foundation | |||
| import XCTest | |||
| import NIO | |||
| import LambdaRuntimeTestUtils | |||
There was a problem hiding this comment.
put below (3 times)
@testable import LambdaRuntime
| @@ -1,10 +1,9 @@ | |||
| import NIO | |||
| import NIOHTTP1 | |||
There was a problem hiding this comment.
NIOHTTP1 can be removed here as well.
mr-j-tree
commented
Jan 13, 2020
There was a problem hiding this comment.
All requested changes have been made. Thanks @fabianfett !!!
fabianfett
approved these changes
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving Environment.forTesting() and Invocation.forTesting() to a new build target, these functions can now be used in your own unit tests when developing Lambda functions in Swift.