-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: Allow attaching Reports to Reports #208
base: master
Are you sure you want to change the base?
feature request: Allow attaching Reports to Reports #208
Conversation
* Define help_info_report styles for Theme in src/config.rs (Similar to help_info_error style) * Implement Display and Debug formatters for HelpInfo::Report
- Added doc comments for both methods - Added two examples for demonstrate methods usage in /examples: multiple_reports_lazy.rs and multiple_reports
Accepted suggestions from
|
Regarding the Since version 22.0, pyo3 seems to be adding support for Python 3.13. My proposal is to update the eyre Cargo.toml as follows: [dependencies]
...
pyo3 = { version = "0.23.1", optional = true, default-features = false }
...
[dev-dependencies]
...
pyo3 = { version = "0.23.1", default-features = false, features = ["auto-initialize"] } @yaahc, would this be a valid approach? I'm open to any suggestions or feedback. |
tenatively that sounds fine, the only concern would be whats the MSRV for that version of pyo3 since we'd inherit it |
Looking at the release history of the |
- Refactored eyre/tests/test_pyo3.rs to support pyo3 version upgrade.
Bump
Observations:
|
Hi, @yaahc I hope you're doing well! When you have some time, could you kindly take a look at my PR? Let me know if anything needs adjustment. Thanks! |
"{}", | ||
error.style(theme.help_info_report) | ||
)?; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have any backtrace or spantrace information in this report, it won't be printed. That feels like a motivating use case for this feature
Implemented a way to properly link additional
color_eyre::Report
s to a Report:report
andwith_report
.closes #198