-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup internals #101
Cleanup internals #101
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,6 @@ | |
/// | ||
/// # fn main() -> Result<()> { | ||
/// # let depth = 0; | ||
/// # let err: &'static dyn std::error::Error = &ScienceError::RecursionLimitExceeded; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was looking at this for a minute trying to figure out why it was there... honestly still not really sure. I'm guessing it has something to do with asserting that edit: seeing you already restored, kinda curious if you figured out why it was necessary. |
||
/// # | ||
/// if depth > MAX_DEPTH { | ||
/// bail!(ScienceError::RecursionLimitExceeded); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what caused the failure of the src/macros.rs
The two versions of syn were conflicting with thiserror