Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Adhere to .easignore even if requireCommit is true #2942

Merged
merged 5 commits into from
Mar 17, 2025

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Mar 12, 2025

Why

#2925 (comment)

How

Delete files from .easignore even if requireCommit is true. Instead of erroring, print a warning.

Test Plan

Adjusted tests.

Copy link

github-actions bot commented Mar 12, 2025

Size Change: -1.65 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.65 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.65%. Comparing base (b07315e) to head (1f05391).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
+ Coverage   52.63%   52.65%   +0.02%     
==========================================
  Files         588      588              
  Lines       23245    23252       +7     
  Branches     4626     4629       +3     
==========================================
+ Hits        12232    12240       +8     
+ Misses      10979    10978       -1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela marked this pull request as ready for review March 12, 2025 11:48
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/allow-easignore-require-commit branch from 55d5bd8 to 5d95fd1 Compare March 12, 2025 11:54
Copy link

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit ef8d6d0 into main Mar 17, 2025
9 checks passed
@sjchmiela sjchmiela deleted the stanley/allow-easignore-require-commit branch March 17, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants