Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share command #2932

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add share command #2932

wants to merge 4 commits into from

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Mar 6, 2025

Related PRs

Why

Closes ENG-15215

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

Copy link

linear bot commented Mar 6, 2025

Copy link

linear bot commented Mar 12, 2025

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

github-actions bot commented Mar 12, 2025

Size Change: +4.25 kB (+0.01%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB +4.25 kB (+0.01%)

compressed-size-action

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 46.25000% with 43 lines in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (1b713af) to head (6c97875).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/share.ts 32.21% 40 Missing ⚠️
...as-cli/src/graphql/mutations/ShareBuildMutation.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
- Coverage   52.64%   52.61%   -0.02%     
==========================================
  Files         588      590       +2     
  Lines       23203    23329     +126     
  Branches     4860     4638     -222     
==========================================
+ Hits        12212    12273      +61     
- Misses      10022    11022    +1000     
+ Partials      969       34     -935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabrieldonadel gabrieldonadel marked this pull request as ready for review March 17, 2025 23:02
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@gabrieldonadel gabrieldonadel marked this pull request as draft March 17, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant