Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update php/docs/intallation.md #882

Merged
merged 6 commits into from
Mar 10, 2025
Merged

update php/docs/intallation.md #882

merged 6 commits into from
Mar 10, 2025

Conversation

A-O-Emmanuel
Copy link
Contributor

@A-O-Emmanuel A-O-Emmanuel commented Mar 5, 2025 •
edited by mk-mxp
Loading

Edit: Closes #864

@A-O-Emmanuel A-O-Emmanuel mentioned this pull request Mar 5, 2025
Closed
@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/docs Work on Documentation x:size/small Small amount of work x:rep/small Small amount of reputation labels Mar 8, 2025
@mk-mxp mk-mxp self-requested a review March 8, 2025 14:02
@mk-mxp
Copy link
Contributor

mk-mxp commented Mar 8, 2025

Thanks for your contribution! I'm in the process of testing the workflow in a new virtual machine. As I have very limited time at the moment, this may take some time. Hopefully no more than a day or two...

mk-mxp
mk-mxp requested changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make phpunit available as a global command like the exercism CLI to enable the testing workflow shown in the PHP track testing docs.

Also, Markdown requires empty lines before / after code blocks and headings. There is a load of Markdown docs for Exercism, but you don't have to read the docs for this PR.

@A-O-Emmanuel
Copy link
Contributor Author

A-O-Emmanuel commented Mar 10, 2025 •
edited
Loading

@mk-mxp I committed the suggestions you made, thank you. Also making phpunit available as a global command like the exercism CLI to enable the testing workflow. Looks like this is already part of the suggestions you made?

@A-O-Emmanuel A-O-Emmanuel requested a review from mk-mxp March 10, 2025 17:35
@mk-mxp
Copy link
Contributor

mk-mxp commented Mar 10, 2025

Thanks for using my suggestions. As you said, I summarized the things I suggested in addition to the Markdown syntax. I'm happy to merge it.

@mk-mxp mk-mxp merged commit 5ef1910 into exercism:main Mar 10, 2025
12 checks passed
@A-O-Emmanuel
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@A-O-Emmanuel A-O-Emmanuel

Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/small Small amount of reputation x:size/small Small amount of work x:type/docs Work on Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: Improve PHP track docs for PHPUnit / composer
2 participants
@A-O-Emmanuel @mk-mxp