Auto-sync instructions #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk-mxp
added
x:action/sync
|
(I will review this tonight or tomorrow) |
homersimpsons
approved these changes
Mar 8, 2025
This file is in fact used to prove that the exercise is solvable. I think some student may read it though. I'm fine keeping it like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-sync with problem specifications.
For
sievethere was a lengthy discussion on the forum about the "using the proper algorithm" note, namely about the use of division or modulo for the prime detection. But I don't think we should change ourexample.phpto match that - it uses modulo to detect multiples instead of looping over multiples of a prime to remove them.