Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions.md with a note #2612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Erz3
Copy link

@Erz3 Erz3 commented Mar 5, 2025

Added note to clarify "ratePerHour" and "dayRate" meaning.

https://forum.exercism.org/t/javascript-freelancer-rates-confused-spelling/16054

Added note to clarify "ratePerHour" and "dayRate" meaning.
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 5, 2025
@SleeplessByte SleeplessByte reopened this Mar 5, 2025
@@ -2,6 +2,10 @@

In this exercise you will be writing code to help a freelancer communicate with their clients about the prices of certain projects. You will write a few utility functions to quickly calculate the costs for the clients.

~~~~exercism/note
In the next tasks, the ==ratePerHour== variable and the ==dayRate== function are related to money. The units of measurement are money for a unit of time (hours and days respectively).
Copy link
Member

@SleeplessByte SleeplessByte Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the next tasks, the ==ratePerHour== variable and the ==dayRate== function are related to money. The units of measurement are money for a unit of time (hours and days respectively).
The `ratePerHour` variable and the `dayRate` function are related to money.
The units of measurement are money for a unit of time: hours and days respectively.

Perhaps like this?

  • ==xxx== means nothing in Markdown, but xxx will format it as monospace (code)
  • Each sentence should be on a new line, even though that's not followed everywhere in this file. We did not have a styleguide when this exercise was written!
  • If you accept this proposal, you can press the Commit suggestion button and it will do it for you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Erz3 Did you have time to look into this proposal? Seems okay to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, It's look fine.

@SleeplessByte Where could I find "Commit suggestion" button? I just saw "close pull request" at the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants