-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tests for armstrong-numbers #2577
Merged
SleeplessByte
merged 6 commits into
exercism:main
from
jagdish-15:update-tests-armstrong-numbers
Jan 22, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8b83b59
Updating tests for armstrong-numbers
jagdish-15 8fc55a0
Implementing BigInt to handle last two test cases
jagdish-15 8591449
Updating test file to implement BigInt
jagdish-15 a0ab2a8
Adding note in the instructions
jagdish-15 44b0ec6
Adding exercism note block
jagdish-15 4a7a625
Fixing the CI, hopefully
Cool-Katt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
exercises/practice/armstrong-numbers/.docs/instructions.append.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<!-- prettier-ignore-start --> | ||
~~~~exercism/note | ||
Some of the tests might pass a `BigInt` as input. | ||
Ensure that your implementation can handle such cases. | ||
~~~~ | ||
<!-- prettier-ignore-end --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
"ankorGH", | ||
"gargrave", | ||
"hayashi-ay", | ||
"jagdish-15", | ||
"ovidiu141", | ||
"SleeplessByte", | ||
"xarxziux" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,12 @@ | ||
export const isArmstrongNumber = (input) => { | ||
const digits = [...String(input)]; | ||
const bigInput = BigInt(input); | ||
|
||
const digits = [...String(bigInput)]; | ||
|
||
const sum = digits.reduce( | ||
(total, current) => total + current ** digits.length, | ||
0, | ||
(total, current) => total + BigInt(current) ** BigInt(digits.length), | ||
BigInt(0), | ||
); | ||
return sum === input; | ||
|
||
return sum === bigInput; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,43 @@ | ||
# This is an auto-generated file. Regular comments will be removed when this | ||
# file is regenerated. Regenerating will not touch any manually added keys, | ||
# so comments can be added in a "comment" key. | ||
# This is an auto-generated file. | ||
# | ||
# Regenerating this file via `configlet sync` will: | ||
# - Recreate every `description` key/value pair | ||
# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications | ||
# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) | ||
# - Preserve any other key/value pair | ||
# | ||
# As user-added comments (using the # character) will be removed when this file | ||
# is regenerated, comments can be added via a `comment` key. | ||
|
||
[c1ed103c-258d-45b2-be73-d8c6d9580c7b] | ||
description = "Zero is an Armstrong number" | ||
|
||
[579e8f03-9659-4b85-a1a2-d64350f6b17a] | ||
description = "Single digit numbers are Armstrong numbers" | ||
description = "Single-digit numbers are Armstrong numbers" | ||
|
||
[2d6db9dc-5bf8-4976-a90b-b2c2b9feba60] | ||
description = "There are no 2 digit Armstrong numbers" | ||
description = "There are no two-digit Armstrong numbers" | ||
|
||
[509c087f-e327-4113-a7d2-26a4e9d18283] | ||
description = "Three digit number that is an Armstrong number" | ||
description = "Three-digit number that is an Armstrong number" | ||
|
||
[7154547d-c2ce-468d-b214-4cb953b870cf] | ||
description = "Three digit number that is not an Armstrong number" | ||
description = "Three-digit number that is not an Armstrong number" | ||
|
||
[6bac5b7b-42e9-4ecb-a8b0-4832229aa103] | ||
description = "Four digit number that is an Armstrong number" | ||
description = "Four-digit number that is an Armstrong number" | ||
|
||
[eed4b331-af80-45b5-a80b-19c9ea444b2e] | ||
description = "Four digit number that is not an Armstrong number" | ||
description = "Four-digit number that is not an Armstrong number" | ||
|
||
[f971ced7-8d68-4758-aea1-d4194900b864] | ||
description = "Seven digit number that is an Armstrong number" | ||
description = "Seven-digit number that is an Armstrong number" | ||
|
||
[7ee45d52-5d35-4fbd-b6f1-5c8cd8a67f18] | ||
description = "Seven digit number that is not an Armstrong number" | ||
description = "Seven-digit number that is not an Armstrong number" | ||
|
||
[5ee2fdf8-334e-4a46-bb8d-e5c19c02c148] | ||
description = "Armstrong number containing seven zeroes" | ||
|
||
[12ffbf10-307a-434e-b4ad-c925680e1dd4] | ||
description = "The largest and last Armstrong number" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other test descriptions needs to be updated to match this.