-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed some grammatical errors in instructions.md and instructions.append.md #2805
base: main
Are you sure you want to change the base?
Conversation
@@ -6,9 +6,9 @@ After some time spent following her best friend's trail, she finds the camp in w | |||
|
|||
Having found the kidnappers, Annalyn considers which of the following actions she can engage in: | |||
|
|||
- Fast attack: a fast attack can be made if the knight is sleeping, as it takes time for him to get his armor on, so he will be vulnerable. | |||
- Fast attack: a fast attack can be made if the knight is sleeping, as it takes time for him to get his armour on, so he will be vulnerable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
armour
is the British spelling.
Exercism uses American spelling for the content (see the Exercism style guide).
@@ -1,6 +1,6 @@ | |||
# Instructions | |||
|
|||
In this exercise you're going to write some code to help you cook a brilliant lasagna from your favorite cooking book. | |||
In this exercise, you're going to write some code to help you cook a brilliant lasagna from your favourite cooking book. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the armour
comment favourite
is the british spelling
@@ -58,7 +58,7 @@ After making corrections and implementing your solution, run the tests again. | |||
You can run the tests using the online editor or locally on your machine: | |||
|
|||
- To run the tests in the online editor, click the "Run Tests" button. | |||
- To run the tests locally, check [Testing on the Java track][Testing locally on the java track] If the tests fails, that's ok! See what the error message is telling you, change your code and test again, when your tests pass, move on to the next step. | |||
- To run the tests locally, check [Testing on the Java track][Testing locally on the java track] If the tests fail, that's ok! See what the error message tells you: change your code and test again; when your tests pass, move on to the next step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using ;
here?
@@ -103,7 +103,7 @@ exercism download --exercise=two-fer --track=java | |||
|
|||
### Become a mentor | |||
|
|||
The heart of Exercism are the conversations about coding practices. | |||
The heart of Exercism is the conversations about coding practices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thin are
was correct here
pull request
This pull request addresses and corrects several grammatical errors in the instructions.md file. The changes include:
Correcting misplaced punctuation.
These revisions enhance the readability and professionalism of the documentation, ensuring that users can understand the instructions more clearly and accurately.
Summary of Changes
Impact
These changes are purely editorial and do not affect the functionality of the codebase. The updates are intended to improve the overall quality and readability of the documentation.
Reviewer Resources:
Track Policies