-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: have test name on one line again #946
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
We have to fix the issue in the test runner test discovery script. |
The pre-commit checks will not let me merge this :D |
Exactly, you need to put
|
Agreed, it's not exactly robust.
I think they mostly do, don't they? What exactly is different? I think I know why I didn't catch this. I ran the test runner on exercises in the |
I can confirm you found them all. |
bfd62af
to
f5b7db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now, thanks for the quick help!
I found some.