Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: have test name on one line again #946

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Feb 27, 2025

I found some.

@vaeng vaeng requested a review from ahans February 27, 2025 16:32
@vaeng vaeng added the x:action/fix Fix an issue label Feb 27, 2025
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@vaeng
Copy link
Contributor Author

vaeng commented Feb 27, 2025

We have to fix the issue in the test runner test discovery script.
And also we should make sure that our tests in the main repository are run under the same conditions as the docker version over in the test-runner.

@vaeng
Copy link
Contributor Author

vaeng commented Feb 27, 2025

The pre-commit checks will not let me merge this :D

@ahans
Copy link
Contributor

ahans commented Feb 27, 2025

The pre-commit checks will not let me merge this :D

Exactly, you need to put // clang-format off and on around a long name, e.g.:

TEST_CASE(
    // clang-format off
    "non-numeric, non-space char in the middle with a sum that's divisible by 10 isn't allowed",
    // clang-format on
    "[8b72ad26-c8be-49a2-b99c-bcc3bf631b33]") {
    REQUIRE(false == luhn::valid("59%59"));
}

@ahans
Copy link
Contributor

ahans commented Feb 27, 2025

We have to fix the issue in the test runner test discovery script.

Agreed, it's not exactly robust.

And also we should make sure that our tests in the main repository are run under the same conditions as the docker version over in the test-runner.

I think they mostly do, don't they? What exactly is different?

I think I know why I didn't catch this. I ran the test runner on exercises in the build_exercises directly that CMake creates, so that the example solutions are in place. I must have accidentally used an old version there. :( TBH, this build_exercises copy is something that I don't particularly like. I will try to come up with something better.

@ahans
Copy link
Contributor

ahans commented Feb 27, 2025

I can confirm you found them all.

@ahans ahans force-pushed the fix--test-names-back-on-one-line branch from bfd62af to f5b7db4 Compare February 27, 2025 17:05
Copy link
Contributor Author

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now, thanks for the quick help!

@vaeng vaeng merged commit deece71 into main Feb 27, 2025
8 checks passed
@vaeng vaeng deleted the fix--test-names-back-on-one-line branch February 27, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants