Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update Material Design Icons to v4.0.0-116-ge9da21 #223

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Sep 15, 2024

Of the 14155 svg files process,

  • 11 new icons added
    • regular/trolley
    • regular/forklift
    • regular/conveyor_belt
    • regular/pallet
    • regular/front_loader
    • regular/assignment_add
    • regular/rebase_edit
    • regular/barcode_reader
    • regular/shelves
    • regular/format_list_bulleted_add
    • regular/movie_edit
  • 35 icons have new sizes
  • 0 icons' sizes were removed
  • 0 icons were replaced or removed

2bndy5 and others added 2 commits September 15, 2024 14:18
Of the 14155 svg files process,
- 11 new icons added
- 35 icons have new sizes
- 0 icons' sizes were removed
- 0 icons were replaced or removed
@2bndy5
Copy link
Contributor Author

2bndy5 commented Sep 15, 2024

Sorry its been so long since my last update of these icons. The google/material-icons repo grew too large for normal checkout (with non-shallow depth) in the CI runner that generates these JSON files... I had to resort to a sparse checkout to get the correct version tag.

@2bndy5

This comment was marked as off-topic.

@2bndy5 2bndy5 changed the title UPDATE Material Design Icons to v4.0.0-116-ge9da21 ⬆️ Update Material Design Icons to v4.0.0-116-ge9da21 Sep 15, 2024
@chrisjsewell
Copy link
Member

codecov action is hitting API rate limit

Its due to this codecov/codecov-action#1293, I haven't found it matters how little uploads you have, its because you are on a fork.
Will deactivate for forks in a bit for now, as have done for other repos

@2bndy5
Copy link
Contributor Author

2bndy5 commented Sep 16, 2024

I can rebase the branch if you want

@chrisjsewell chrisjsewell merged commit 18afa33 into executablebooks:main Sep 16, 2024
15 checks passed
@2bndy5 2bndy5 deleted the update-md-icons branch September 16, 2024 22:13
@2bndy5
Copy link
Contributor Author

2bndy5 commented Sep 16, 2024

Oh, I see you added a regression test. I'll be sure to adhere to this in the future.

@chrisjsewell
Copy link
Member

yeh no worries, it was something I'd already done for octicons, and makes it clearer in the git diff to check for breaking changes, i.e. removed icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants