New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unused constants #205

Open

ftnext wants to merge 1 commit into executablebooks:main from ftnext:octicon-role-unused-constants

ftnext commented Jul 1, 2024

Thank you for this awesome library.
I referred to the implementation of the octicon role in icons.py (a3bdfa3).

In reading the implementation, I noticed some unused code, so I propose to remove it.

$ git grep OCTICON_CSS
sphinx_design/icons.py:OCTICON_CSS = """\
$ git grep OCTICON_VERSION
sphinx_design/icons.py:OCTICON_VERSION = "v19.8.0"


          refactor: Remove unused constants

e9691c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet