Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Remove duplicate CSS hashing for sphinx >= 7.1 #193

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented May 21, 2024

Since sphinx v7.1, a checksum is already added to the CSS file URL, so hashing the content is no longer necessary (see sphinx-doc/sphinx#11415)

Since sphinx v7.1, a checksum is added to the css file URL, so hashing the name is no longer necessary (sphinx-doc/sphinx#11415)
@chrisjsewell chrisjsewell changed the title 👌 Remove CSS hashing for sphinx >= 7.1 👌 Remove duplicate CSS hashing for sphinx >= 7.1 May 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (be1b85d) to head (fbb402b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   89.15%   89.18%   +0.03%     
==========================================
  Files          11       11              
  Lines         959      962       +3     
==========================================
+ Hits          855      858       +3     
  Misses        104      104              
Flag Coverage Δ
pytests 89.18% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 074f21f into main May 21, 2024
15 checks passed
@chrisjsewell chrisjsewell deleted the checksum branch May 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants