Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add types field to exports in package.json #218

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

eventualbuddha
Copy link
Owner

Replacement for #217, since I needed to change the commit message but couldn't on @sosukesuzuki's fork.

@sosukesuzuki
Copy link
Contributor

Thank you

@sosukesuzuki
Copy link
Contributor

This can be merged?

@danielegarciav
Copy link

Indeed this should be able to fix the problem at #217 which is explained in are-the-types-wrong's article for untyped resultion. I can confirm patching the module with the change fixes the problem.

Is there anything else needed to merge this?

@eventualbuddha eventualbuddha merged commit eea2581 into main Nov 7, 2023
3 checks passed
@eventualbuddha eventualbuddha deleted the pr/sosukesuzuki/217 branch November 7, 2023 01:41
Copy link

github-actions bot commented Nov 7, 2023

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants