[BAEL-8962] Check if a code compiles in Java using JavaCompiler #18358
Conversation
...a-modules/core-java-compiler/src/main/java/com/baeldung/compilerApi/JavaCompilerApiDemo.java
Outdated
Show resolved
Hide resolved
...ava-modules/core-java-compiler/src/main/java/com/baeldung/compilerApi/JavaCompilerUtils.java
Outdated
Show resolved
Hide resolved
...java-modules/core-java-compiler/src/test/java/com/baeldung/compilerApi/JavaCompilerTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void testCompileFromString_Success() { |
There was a problem hiding this comment.
We use given_when_then or when_then BDD style syntax for test names (same elsewhere)
dhrubo55
force-pushed
the
BAEL-8962-Check-if-a-code-compiles-in-Java-using-JavaCompiler
branch
from
e173bdc to
e63c994
Compare
|
|
||
|
|
||
| JavaCompiler.CompilationTask task = compiler.getTask( | ||
| null, // Writer for compiler output |
There was a problem hiding this comment.
| null, // Writer for compiler output | |
| null, // Writer for compiler output |
| return success; | ||
| } | ||
|
|
||
| // Add this method to JavaCompilerUtils |
| private boolean compile(Iterable<? extends JavaFileObject> compilationUnits) { | ||
| DiagnosticCollector<JavaFileObject> diagnostics = new DiagnosticCollector<>(); | ||
|
|
||
|
|
| loadedClass.getMethod("main", String[].class).invoke(null, (Object) args); | ||
| } | ||
| } | ||
|
|
| } | ||
|
|
||
| @Test | ||
| void given_simpleHelloWorldClass_when_compiledFromString_then_compilationSucceeds() { |
There was a problem hiding this comment.
This is not the right syntax, see the suggestion for the syntax we require
| void given_simpleHelloWorldClass_when_compiledFromString_then_compilationSucceeds() { | |
| void givenSimpleHelloWorldClass_whenCompiledFromString_thenCompilationSucceeds() { |
|
|
||
| @Test | ||
| void given_simpleHelloWorldClass_when_compiledFromString_then_compilationSucceeds() { | ||
| // Simple "Hello World" class |
There was a problem hiding this comment.
Remove all the comments from the tests, the assertion messages and test layout should speak for itself
| <dependency> | ||
| <groupId>com.github.stefanbirkner</groupId> | ||
| <artifactId>system-lambda</artifactId> | ||
| <version>1.2.1</version> |
There was a problem hiding this comment.
Extract a version number property (this is another mandatory guideline)
| DiagnosticCollector<JavaFileObject> diagnostics = new DiagnosticCollector<>(); | ||
|
|
||
| JavaCompiler.CompilationTask task = compiler.getTask( | ||
| null, // Writer for compiler output |
There was a problem hiding this comment.
The alignment is still not correct here. Please review it visually and fix it.
| /** | ||
| * A utility class for compiling Java source code using the Java Compiler API. | ||
| * This class provides methods to compile Java code from strings or files. | ||
| */ |
There was a problem hiding this comment.
I was also advised by the team that we have guidelines to not use comments to add explanations for the code. All the required explanations should be in the text. Can you please remove the comments and JavaDoc from the PR to address this, and move any comments that are important to note into the article text instead.
No description provided.