New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid zero division in RayCaster::setupRayCaster #418

Open

Naoki-Hiraoka wants to merge 1 commit into ethz-asl:master from Naoki-Hiraoka:ray-zero-division

Naoki-Hiraoka commented Jul 1, 2024 •

edited

Loading

When I executed the following code, I got a strange result.

GlobalIndex global_voxel_idx;
RayCaster ray_caster(Point(0.0,0.0,0.0), Point(0.0,1.0,0.0), false,
                     true,
                     5.0, 1 / 0.2,
                     0.1, false);
while (ray_caster.nextRayIndex(&global_voxel_idx)) {
  std::cout << global_voxel_idx.transpose() << std::endl;
 }

The expected result is

This is because there are zero divisions in RayCaster::setupRayCaster.
This Pull Request fixes this problem.


          avoid zero division in RayCaster::setupRayCaster

25dca67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet