-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: fix recursiveNodeLookup #669
Conversation
I didn't realize that this method was used by Glados. We otherwise only use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added some fixes for the *traceGetContent
work in the contentLookup
folder related to glados-audit
Bug unconvered through use of
glados-cartographer
portal_*RecursiveFindContent
was not returning the expected array of ENRs.Changes:
refresh
parameterNodeLookup
will exit early when the target bucket is fullbucketRefresh
NodeLookup
now tracks all found ENRs in aHeap
calledthis.foundNodes
Heap
is automatically sorted by distance to targetNodeLookup.startLookup()
now returns the closest 16 ENRs fromfoundNodes
heapENR
string array (sorted)portal_*RecursiveFindNodes
now returns ENR list fromNodeLookup.startLookup()
This PR also implements the same method for
state
andbeacon
networks, which were previously without this method.