fix: missing KeyError and incorrect existence checking when changing default node #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/smt-default-checks
branch
2 times, most recently
from
a084c5e to
658039f
Compare
antazoey
force-pushed
the
fix/smt-default-checks
branch
from
658039f to
fc179a8
Compare
antazoey
force-pushed
the
fix/smt-default-checks
branch
from
3de0fda to
11b8165
Compare
antazoey
force-pushed
the
fix/smt-default-checks
branch
from
11b8165 to
9a79146
Compare
antazoey
commented
Jan 30, 2024
| @@ -252,7 +252,7 @@ def get(self, key: bytes) -> bytes: | |||
| value, _ = self._get(key) | |||
|
|
|||
| # Ensure that it isn't blank! | |||
| if value == BLANK_NODE: | |||
| if value == self._default: | |||
There was a problem hiding this comment.
Realizing this is not probably, wanted.
If this default is anything other than a blank
node, then all keys "exist" in the database, which mimics the behavior of
Ethereum on-chain datastores.
(from the docs)
will change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #
fixes #129
How was it fixed?
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture