Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement standalone RLP encoding for uint64 to decouple from EVM state #815

Closed

Conversation

AbhinavMir
Copy link

potential fix #783

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e4bcf7c) to head (285a4d5).
Report is 328 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e4bcf7c) and HEAD (285a4d5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e4bcf7c) HEAD (285a4d5)
unittests 1 0
statetests-silkpre 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #815       +/-   ##
==========================================
- Coverage   97.79%   0.00%   -97.80%     
==========================================
  Files         110      18       -92     
  Lines       10822    1361     -9461     
==========================================
- Hits        10583       0    -10583     
+ Misses        239       0      -239     
Flag Coverage Δ
blockchaintests 59.88% <ø> (ø)
statetests-silkpre ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 108 files with indirect coverage changes

@AbhinavMir AbhinavMir marked this pull request as ready for review February 12, 2024 01:16
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this does not look good at all. This code doesn't even build.

The job is to copy rlp:: utils here and trim it to what is needed for computing the create address. Which is: encode uint64_t number, encode the 20-byte address, and finally the RLP list of these two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute CREATE address without RLP library
2 participants