Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment transaction sender's nonce before entering execution frame #1021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 19, 2024

This is required for EIP-7702 implementation, because there the sender's nonce must be bumped before processing transaction's Authorization List.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (4a3cb41) to head (b75dc52).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   94.18%   94.19%           
=======================================
  Files         149      149           
  Lines       15884    15887    +3     
=======================================
+ Hits        14961    14964    +3     
  Misses        923      923           
Flag Coverage Δ
eof_execution_spec_tests 17.23% <100.00%> (+0.01%) ⬆️
ethereum_tests 27.32% <87.50%> (+0.01%) ⬆️
ethereum_tests_silkpre 19.12% <87.50%> (+0.01%) ⬆️
execution_spec_tests 20.42% <87.50%> (+0.01%) ⬆️
unittests 88.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/state.cpp 88.59% <100.00%> (+0.07%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant