C++: Refactor {address,bytes32} constructors #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
May 18, 2022
| {} | ||
| inline constexpr explicit address(uint64_t v) noexcept : evmc_address{} | ||
| { | ||
| for (size_t i = sizeof(bytes) - sizeof(v); i < sizeof(bytes); ++i) |
This replaces std::error_code and exceptions with std::optional<bytes> to inform about invalid hex input.
chfast
force-pushed
the
hex_literals
branch
3 times, most recently
from
4fa9b27
to
67ad485
Compare
chfast
force-pushed
the
hex_literals
branch
2 times, most recently
from
060c177
to
940787d
Compare
axic
approved these changes
Jun 16, 2022
|
@chfast what happened to this? |
|
@chfast merge or not? |
|
@chfast still on the verge of merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #644