Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6404: Move to Draft #8872

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

etan-status
Copy link
Contributor

EIP-6493 mixes the introduction of SSZ transactions converted from RLP with native SSZ transactions, implying that the corresponding Receipt definition and engine API changes also must be part of EIP-6493.

Splitting the RLP converted transactions into the other SSZ transaction EIP-6404 achieves a clearer balance, and is also closer to practical implementation order where an EL initially may choose to support only RLP converted transactions before adding the native SSZ profiles.

@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft t-core labels Sep 6, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 6, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 6, 2024
@eth-bot eth-bot enabled auto-merge (squash) September 6, 2024 19:56
eth-bot
eth-bot previously approved these changes Sep 6, 2024
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Sep 6, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 6, 2024
auto-merge was automatically disabled September 6, 2024 20:09

Head branch was pushed to by a user without write access

@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 6, 2024
@eth-bot eth-bot enabled auto-merge (squash) September 6, 2024 20:10
auto-merge was automatically disabled September 6, 2024 20:10

Head branch was pushed to by a user without write access

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Sep 6, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 6, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 6, 2024
@eth-bot eth-bot enabled auto-merge (squash) September 6, 2024 20:11
eth-bot
eth-bot previously approved these changes Sep 6, 2024
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

The commit 1ae6c3b (as a parent of 79d4c36) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 6, 2024
auto-merge was automatically disabled September 6, 2024 20:22

Head branch was pushed to by a user without write access

@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 6, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 8, 2024
@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Sep 8, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 8, 2024
@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Sep 8, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions from EIP-6493 for clarity Update EIP-6404: Move to Draft Sep 8, 2024
@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Sep 8, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Update EIP-6404: Move to Draft Sep 8, 2024
@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Sep 8, 2024
etan-status added a commit to etan-status/EIPs that referenced this pull request Sep 12, 2024
To unstuck ethereum#8872, have to move this EIP to draft so that EIP-6493 which
this refers to can be edited.
etan-status added a commit to etan-status/EIPs that referenced this pull request Sep 12, 2024
To unstuck ethereum#8872, have to move this EIP to draft so that parts from
EIP-6493 can be moved to it.
EIP-6493 mixes the introduction of SSZ transactions converted from RLP
with native SSZ transactions, implying that the corresponding Receipt
definition and engine API changes also must be part of EIP-6493.

Splitting the RLP converted transactions into the other SSZ transaction
EIP-6404 achieves a clearer balance, and is also closer to practical
implementation order where an EL initially may choose to support only
RLP converted transactions before adding the native SSZ profiles.
@github-actions github-actions bot added the c-update Modifies an existing proposal label Sep 12, 2024
@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Update EIP-6404: Move to Draft Sep 12, 2024
@etan-status etan-status changed the title Update EIP-6404: Move to Draft Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Sep 12, 2024
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot changed the title Update EIP-6404: Split RLP conversions and Receipt from EIP-6493 Update EIP-6404: Move to Draft Sep 15, 2024
@eth-bot eth-bot enabled auto-merge (squash) September 15, 2024 11:46
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit f3deac8 into ethereum:master Sep 15, 2024
22 of 23 checks passed
@etan-status etan-status deleted the sz-split branch September 16, 2024 10:00
@Mikhai56
Copy link

no artifacts found

@Mikhai56
Copy link

f3deac8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status c-update Modifies an existing proposal e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants