-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-6404: Move to Draft #8872
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Head branch was pushed to by a user without write access
6e6c344
to
a2c7239
Compare
Head branch was pushed to by a user without write access
a2c7239
to
1ae6c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
The commit 1ae6c3b (as a parent of 79d4c36) contains errors. |
Head branch was pushed to by a user without write access
1ae6c3b
to
45f7ee4
Compare
85e84fd
to
add33c0
Compare
add33c0
to
1fb768e
Compare
1fb768e
to
b34f4d9
Compare
Receipt
from EIP-6493
b34f4d9
to
dd1b078
Compare
Receipt
from EIP-6493Receipt
from EIP-6493
To unstuck ethereum#8872, have to move this EIP to draft so that EIP-6493 which this refers to can be edited.
To unstuck ethereum#8872, have to move this EIP to draft so that parts from EIP-6493 can be moved to it.
EIP-6493 mixes the introduction of SSZ transactions converted from RLP with native SSZ transactions, implying that the corresponding Receipt definition and engine API changes also must be part of EIP-6493. Splitting the RLP converted transactions into the other SSZ transaction EIP-6404 achieves a clearer balance, and is also closer to practical implementation order where an EL initially may choose to support only RLP converted transactions before adding the native SSZ profiles.
dd1b078
to
aa717e5
Compare
Receipt
from EIP-6493Receipt
from EIP-6493
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Receipt
from EIP-6493There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
no artifacts found |
EIP-6493 mixes the introduction of SSZ transactions converted from RLP with native SSZ transactions, implying that the corresponding Receipt definition and engine API changes also must be part of EIP-6493.
Splitting the RLP converted transactions into the other SSZ transaction EIP-6404 achieves a clearer balance, and is also closer to practical implementation order where an EL initially may choose to support only RLP converted transactions before adding the native SSZ profiles.