Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove DisputeGameFactory input from SystemConfig #14820

Merged
merged 8 commits into from
Mar 13, 2025

Conversation

smartcontracts
Copy link
Contributor

Updates the SystemConfig to kill the DisputeGameFactory input. By getting this address from the OptimismPortal we can remove the need for unnecessary inputs that would have to be changed if the DisputeGameFactory changes.

Updates the SystemConfig to kill the DisputeGameFactory input. By
getting this address from the OptimismPortal we can remove the
need for unnecessary inputs that would have to be changed if the
DisputeGameFactory changes.
@smartcontracts smartcontracts requested a review from a team as a code owner March 12, 2025 17:38
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (30bde93) to head (cc16b2f).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14820      +/-   ##
===========================================
- Coverage    46.82%   46.80%   -0.02%     
===========================================
  Files         1046     1046              
  Lines        90847    90850       +3     
===========================================
- Hits         42537    42524      -13     
- Misses       45185    45203      +18     
+ Partials      3125     3123       -2     
Flag Coverage Δ
cannon-go-tests-32 62.08% <ø> (ø)
cannon-go-tests-64 57.13% <ø> (ø)
contracts-bedrock-tests 94.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 97.49% <100.00%> (+<0.01%) ⬆️
packages/contracts-bedrock/src/L1/SystemConfig.sol 93.85% <100.00%> (+0.10%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts smartcontracts added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025
@smartcontracts smartcontracts added this pull request to the merge queue Mar 12, 2025
Merged via the queue into develop with commit af09175 Mar 13, 2025
46 checks passed
@smartcontracts smartcontracts deleted the sc/system-config-dgf-rm branch March 13, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants