-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove DisputeGameFactory input from SystemConfig #14820
Merged
Merged
+59
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SystemConfig to kill the DisputeGameFactory input. By getting this address from the OptimismPortal we can remove the need for unnecessary inputs that would have to be changed if the DisputeGameFactory changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14820 +/- ##
===========================================
- Coverage 46.82% 46.80% -0.02%
===========================================
Files 1046 1046
Lines 90847 90850 +3
===========================================
- Hits 42537 42524 -13
- Misses 45185 45203 +18
+ Partials 3125 3123 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
maurelian
reviewed
Mar 12, 2025
maurelian
approved these changes
Mar 12, 2025
mds1
reviewed
Mar 12, 2025
mds1
reviewed
Mar 12, 2025
mds1
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SystemConfig to kill the DisputeGameFactory input. By getting this address from the OptimismPortal we can remove the need for unnecessary inputs that would have to be changed if the DisputeGameFactory changes.