Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize: fix round counter error in binding events logger #2061

Merged
merged 1 commit into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. materialize: fix round counter error in binding events logger

    The round counter is incremented when the materialization starts its commit, and
    the general idea of starting the entire commit happens before performing the
    sub-operations for committing to each resource. So the "round" counter for
    committing to each resource is actually 1 less than currently tabulated.
    
    The "round" counter offset by 1 is overall pretty convoluted and I may need to
    think about some kind of "load round" counter instead that stores are associated
    with, although I'm not sure that would be any better. The async operations of
    the materialization protocol just makes this a bit tricky
    williamhbaker committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6ffca1b View commit details
    Browse the repository at this point in the history