source-postgres: Discover OIDs as integers and add tests #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously OID values "worked" (they've always been captured as
integer values and it was possible to use them as the backfill
key as far as the connector was concerned), but were discovered
as the catch-all schema `{}` which meant that OID primary keys
would produce a collection with an invalid collection key.
This commit fixes that by changing OID discovery to say they're
integers, and adds some test cases to make sure OIDs work as we
intend both as values and as primary keys.
willdonnelly
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously OID values "worked" (they've always been captured as integer values and it was possible to use them as the backfill key as far as the connector was concerned), but were discovered as the catch-all schema
{}which meant that OID primary keys would produce a collection with an invalid collection key.This commit fixes that by changing OID discovery to say they're integers, and adds some test cases to make sure OIDs work as we intend both as values and as primary keys.
This change is