Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase number of cells from 16 to 18 #4571

Closed
wants to merge 3 commits into from
Closed

increase number of cells from 16 to 18 #4571

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04e6324
increase number of cells from 16 to 18
j-sepul Jan 9, 2025
4da0af4
increase number of cells from 16 to 18
j-sepul Jan 10, 2025
9b7b1ec
Update components/sensor/daly_bms.rst
jesserockz Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/sensor/daly_bms.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Configuration variables:
- **temperature_2** (*Optional*): The second temperature sensor.
All options from :ref:`Sensor <config-sensor>`.

- **cell_1_voltage** (*Optional*): The voltage of cell number 1. Cell number can be from 1 to 16.
- **cell_1_voltage** (*Optional*): The voltage of cell number 1. Cell number can be from 1 to 18.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Documentation needs additional updates for consistency

The cell range update from 16 to 18 is incomplete. Please address:

  • Add maximum value information to the cells_number configuration description
  • Document all individual cell voltage sensors (cell_5_voltage through cell_18_voltage) in the YAML configuration section
🔗 Analysis chain

Documentation update looks good!

The cell range update from 16 to 18 cells is correctly documented.

Let's verify if there are any other references to cell numbers that might need updating:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any mentions of cell numbers or ranges in the documentation
rg -i "cell.*(16|18)" .
rg -i "cells.*(16|18)" .

Length of output: 760

Script:

#!/bin/bash
# Search for numeric ranges and cell-related configs in Daly BMS files
rg -i "cell" ./components/sensor/daly_bms.rst
# Look for implementation files
fd -e cpp -e h "daly" .

Length of output: 1174

Script:

#!/bin/bash
# Get more context around cells_number configuration
rg -A 2 -B 2 "cells_number" ./components/sensor/daly_bms.rst
# List all individual cell voltage configurations
rg "cell_\d+_voltage" ./components/sensor/daly_bms.rst

Length of output: 641

All options from :ref:`Sensor <config-sensor>`.

Text Sensor
Expand Down
Loading