Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx_copybutton to code-blocks #4530

Open
wants to merge 2 commits into
base: current
Choose a base branch
from
Open

Conversation

shvmm
Copy link
Contributor

@shvmm shvmm commented Dec 22, 2024

Description:

Add sphinx_copybutton to code-blocks

Source: https://sphinx-copybutton.readthedocs.io/en/latest/

Related issue (if applicable): fixes NONE

Pull request in esphome with YAML changes (if applicable): esphome/esphome# NONE

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 083a40d
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6770fa7695919c00081b9550
😎 Deploy Preview https://deploy-preview-4530--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shvmm shvmm marked this pull request as ready for review December 22, 2024 15:53
Copy link
Contributor

coderabbitai bot commented Dec 22, 2024

Walkthrough

The pull request introduces the sphinx_copybutton Sphinx extension to the ESPHome documentation configuration. This extension allows users to easily copy code snippets from the rendered documentation. Additionally, the project version has been updated to "2024.12" and "2024.12.2", and the linkcheck_ignore list has been modified to include patterns for ignoring certain GitHub and Discord links during documentation link checking.

Changes

File Changes
conf.py - Added sphinx_copybutton to extensions list
- Updated version to "2024.12"
- Updated release to "2024.12.2"
- Added GitHub and Discord link ignore patterns to linkcheck_ignore
requirements.txt - Added sphinx-copybutton==0.5.2 dependency

Sequence Diagram

sequenceDiagram
    participant User
    participant Documentation
    participant CopyButton
    
    User->>Documentation: View documentation
    Documentation->>CopyButton: Render copy button
    User->>CopyButton: Click copy button
    CopyButton->>User: Copy code snippet to clipboard
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5ec17 and 083a40d.

📒 Files selected for processing (2)
  • conf.py (1 hunks)
  • requirements.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • requirements.txt
  • conf.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
conf.py (1)

Line range hint 214-214: Consider narrowing down the linkcheck ignore patterns.

The current patterns (r"https://github.com/.*" and r"https://discord.gg/.*") will ignore ALL GitHub and Discord links during link checking. This might hide broken links to important resources.

Consider:

  1. Limiting GitHub ignores to specific paths or organizations
  2. Only ignoring Discord invite links that are known to expire

Example of more specific patterns:

-linkcheck_ignore = [r"https://github.com/.*", r"https://discord.gg/.*"]
+linkcheck_ignore = [
+    r"https://github.com/esphome/.*",  # Only ignore esphome org links
+    r"https://discord.gg/KhAMKrd",  # Only ignore specific Discord invite
+]
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6bb477 and 9c5ec17.

📒 Files selected for processing (2)
  • conf.py (1 hunks)
  • requirements.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • requirements.txt
🧰 Additional context used
📓 Path-based instructions (1)
conf.py (1)

Pattern **: - Do not generate or add any sequence diagrams

🔇 Additional comments (2)
conf.py (2)

Line range hint 82-85: LGTM! Version numbers are consistent.

The version (2024.12) and release (2024.12.2) numbers are properly updated and follow the expected format.


48-48: LGTM! Verify sphinx-copybutton dependency.

The extension is correctly added to the configuration.

Let's verify the dependency is properly declared:

✅ Verification successful

Extension and dependency properly configured

The sphinx-copybutton extension is correctly added to the configuration and its dependency is properly declared in requirements.txt with version 0.5.2.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if sphinx-copybutton is declared in requirements.txt
rg -l "sphinx-copybutton" "requirements.txt"

Length of output: 59


Script:

#!/bin/bash
# Check the actual declaration of sphinx-copybutton in requirements.txt
rg "sphinx-copybutton" requirements.txt

Length of output: 64

@shvmm shvmm closed this Dec 23, 2024
@shvmm shvmm deleted the patch-4 branch December 23, 2024 07:51
@shvmm shvmm restored the patch-4 branch December 23, 2024 07:55
@shvmm shvmm reopened this Dec 23, 2024
Add sphinx_copybutton to code-blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant