Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JSON plugin #1

Merged
merged 19 commits into from
Jul 2, 2024
Merged

feat: Add JSON plugin #1

merged 19 commits into from
Jul 2, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 27, 2024

This PR sets up the baseline for the JSON plugin and this repo.

Some notes:

  • I purposely kept the implementation simple and only implemented the things necessary to create the first couple of rules. This doesn't preclude adding more functionality to JSONSourceCode later on.
  • I also purposely kept the documentation light. We can always add more as we go.
  • This currently supports both JSON and JSONC. I'll spend some time looking at JSON5 later on.
  • The two rules were the only ones I could think of off the top of my head. We can definitely add more later on. These were the simplest proofs-of-concept that I could come up with.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mdjermanovic
Copy link
Member

I think the whole tests/fixtures folder can be removed.

.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/change.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-rule.yml Outdated Show resolved Hide resolved
nzakas and others added 5 commits July 2, 2024 11:08
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 1976f2c into main Jul 2, 2024
11 checks passed
@mdjermanovic mdjermanovic deleted the main-plugin branch July 2, 2024 20:37
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants