-
-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
lib/index.js
Outdated
@@ -24,6 +24,8 @@ function filterKey(key) { | |||
return !KEY_BLACKLIST.has(key) && key[0] !== "_"; | |||
} | |||
|
|||
|
|||
/* eslint-disable jsdoc/valid-types -- doesn't allow `readonly`. TODO: check why */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, readonly string[]
is considered invalid by jsdoc/valid-types
. I disabled the rule here until we figure out what's the problem because changing this type would affect the types this package publishes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth opening an issue on the plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. The issue template suggested opening an issue on the parser, here it is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like jsdoc-type-pratt-parser/jsdoc-type-pratt-parser#164 won't be fixed anytime soon since there's still no response.
lib/visitor-keys.js
Outdated
@@ -1,6 +1,8 @@ | |||
/* eslint-disable jsdoc/valid-types -- doesn't allow `readonly`. TODO: check why */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also reported in jsdoc-type-pratt-parser/jsdoc-type-pratt-parser#164
d4c7bba
to
cdd19cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Switches to flat config for linting this project.