fix: prepend eslint default configs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default config in ESLint is always prepended to the config before it uses the config, making it so that `**/*.js`, `**/*.mjs`, `**/*.cjs` are always matching file patterns: https://github.com/eslint/eslint/blob/21d3766c3f4efd981d3cc294c2c82c8014815e6e/lib/config/default-config.js#L66-L69 This PR copies those two configs and prepends them here as well, with some added names for them to make sense. This is somewhat of a blunt fix. UI-wise it can be handled better and ideally one or more of `defaultConfig`, `FlatConfigArray` and `calculateConfigArray` would be exposed by ESLint so that this inspector can make use of the very same logic rather than attempt to reimplement it. If additionally `defaultConfig` were to eg. add names, then this inspector could opt to eg. hide all `eslint/` prefixed rules and as such get the correct prepended config without having to confuse users with showing a config they never themselves added
voxpelli
commented
Jun 21, 2024
Comment on lines
+121
to
+127
| { | ||
| name: 'eslint/defaults/ignores', | ||
| ignores: [ | ||
| '**/node_modules/', | ||
| '.git/', | ||
| ], | ||
| } as FlatConfigItem, |
There was a problem hiding this comment.
Can remove them from here then:
config-inspector/src/configs.ts
Lines 186 to 190 in f22548b
There was a problem hiding this comment.
I don't mind either way - in the end this globbing things is more or less a approximation for reference. Would be nice if we could reuse the ESLint's logic to get the same result. Otherwise I see no much differences, and honestly would slightly prefer to keep it as-is to make sure we don't over scan.
There was a problem hiding this comment.
@antfu Added a request to expose the ESLint logic: eslint/eslint#18619
antfu
changed the title
Merged
voxpelli
added a commit
to neostandard/neostandard
that referenced
this pull request
Jun 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default config in ESLint is always prepended to the config before it uses the config, making it so that
**/*.js,**/*.mjs,**/*.cjsare always matching file patterns: https://github.com/eslint/eslint/blob/21d3766c3f4efd981d3cc294c2c82c8014815e6e/lib/config/default-config.js#L66-L69This PR copies those two configs and prepends them here as well, with some added names for them to make sense.
This is somewhat of a blunt fix. UI-wise it can be handled better and ideally one or more of
defaultConfig,FlatConfigArrayandcalculateConfigArraywould be exposed by ESLint so that this inspector can make use of the very same logic rather than attempt to reimplement it.If additionally
defaultConfigwere to eg. add names, then this inspector could opt to eg. hide alleslint/prefixed rules and as such get the correct prepended config without having to confuse users with showing a config they never themselves added