Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: drop support for ESLint older than 8 #235

Closed
wants to merge 1 commit into from
Closed

Conversation

voxpelli
Copy link
Member

Fixes #233

Companion PR to #234

Opted to not specify any specific minimum minor version for some reason:

  • Wasn't done in the old version ranges
  • No clear candidate from Drop older ESLint versions from peerDependencies #233 (comment) – either one of >=8.23.0, >=8.56.0, ^8.57.0 would make sense – but would require needless bumps by users of eslint-utils
  • Not clear that there are something in the code of eslint-utils that requires a newer version

I guess >=8.23.0 could make sense as that's where the new flat config format was introduced, https://eslint.org/blog/2022/08/eslint-v8.23.0-released/, any opinions?

@voxpelli voxpelli self-assigned this Sep 18, 2024
@voxpelli voxpelli added the BREAKING CHANGE This change will require a major version bump label Sep 18, 2024
@voxpelli voxpelli requested a review from a team September 18, 2024 15:23
@voxpelli
Copy link
Member Author

@MichaelDeBoey How does the auto-release handle the merge of two PR:s like this and #234? Will there be a double bump in the major version?

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update GitHub workflows as well

@voxpelli
Copy link
Member Author

voxpelli commented Oct 2, 2024

We should update GitHub workflows as well

True, any opinion on the change itself? Or response to my question? :)

@MichaelDeBoey
Copy link
Member

@voxpelli To answer your question: you should create a separate branch (if it's called alpha or beta, you also release an alpha/beta release to NPM) and merge these PRs into that new branch

Once all breaking changes are done, you can merge the new branch into main and you'll only have 1 major release.

If you merge both PRs directly to main, it could be that you're release 2 major versions, depending on how quick you are

@MichaelDeBoey
Copy link
Member

Superseded by #243

@MichaelDeBoey MichaelDeBoey deleted the voxpelli/issue233 branch October 26, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop older ESLint versions from peerDependencies
2 participants